Propagate DynamicallyAccessedMembersAttribute to type inference method #11856
+800
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsienki
approved these changes
May 13, 2025
| @@ -445,6 +447,64 @@ private static void CreateTypeParameterProperty(TagHelperDescriptorBuilder build | |||
| metadataPairs.Add(new(ComponentMetadata.Component.TypeParameterConstraintsKey, whereClauseText)); | |||
| } | |||
|
|
|||
| // Collect attributes that should be propagated to the type inference method. | |||
| var withAttributes = StringBuilderPool.GetPooledObject(); | |||
There was a problem hiding this comment.
Is there a reason not to use the standard using pattern for pooled objects? After all, that's the pattern used in the code above for metadataPairs and would avoid all of the extra accesses for Object below.
using var _ = StringBuilderPool.GetPooledObject(out var withAtttributes);
|
@333fred @DustinCampbell @dotnet/razor-compiler for a second review, thanks |
333fred
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11718.
Review commit-by-commit to see codegen diff.